Re: [PATCH][next] net: phy: fix less than zero comparison with unsigned variable val

From: David Miller
Date: Thu May 07 2020 - 21:08:02 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Thu, 7 May 2020 15:34:30 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The unsigned variable val is being checked for an error by checking
> if it is less than zero. This can never occur because val is unsigned.
> Fix this by making val a plain int.
>
> Addresses-Coverity: ("Unsigned compared against zero")
> Fixes: bdbdac7649fa ("ethtool: provide UAPI for PHY master/slave configuration.")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied, thanks Colin.