Re: [RESENT PATCH RFC v3 4/5] scsi: ufs: add unit and geometry parameters for HPB

[Bean Huo]

On Thu, 2020-05-07 at 18:04 -0700, Bart Van Assche wrote:
> > +     GEOMETRY_DESC_PARAM_HPB_REGION_SIZE     = 0x48,
> > +     GEOMETRY_DESC_PARAM_HPB_NUMBER_LU       = 0x49,
> > +     GEOMETRY_DESC_PARAM_HPB_SUBREGION_SIZE  = 0x4A,
> > +     GEOMETRY_DESC_PARAM_HPB_MAX_ACTIVE_REGIONS = 0x4B,
> >   };
> 
> How about adding the names from the spec as a comment above the new
> constants, e.g. as follows?
> 
>         /* wHPBPinnedRegionStartIdx */
>         UNIT_DESC_PARAM_HPB_PIN_REGION_START_OFFSET = 0x25,
> 
> Thanks,
> 
> Bart.

Bart
I will add in the next version.

thanks,

Bean