Re: [PATCH -next] brcmfmac: make non-global functions static

[Wright Feng]

Chen Zhou æ 5/8/2020 9:32 AM åé:
> Fix sparse warning:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2206:5:
> 	warning: symbol 'brcmf_p2p_get_conn_idx' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Chen Zhou <chenzhou10@xxxxxxxxxx>
Reviewed-by: Wright Feng <wright.feng@xxxxxxxxxxx>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> index e32c24a2670d..2a2440031357 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> @@ -2203,7 +2203,7 @@ static struct wireless_dev *brcmf_p2p_create_p2pdev(struct brcmf_p2p_info *p2p,
>   	return ERR_PTR(err);
>   }
>   
> -int brcmf_p2p_get_conn_idx(struct brcmf_cfg80211_info *cfg)
> +static int brcmf_p2p_get_conn_idx(struct brcmf_cfg80211_info *cfg)
>   {
>   	int i;
>   	struct brcmf_if *ifp = netdev_priv(cfg_to_ndev(cfg));