Re: [PATCH 00/17] spi: dw: Add generic DW DMA controller support

From: Andy Shevchenko
Date: Fri May 08 2020 - 15:16:22 EST


On Fri, May 08, 2020 at 06:36:09PM +0100, Mark Brown wrote:
> On Fri, May 08, 2020 at 04:29:25PM +0300, Serge Semin wrote:
> > Baikal-T1 SoC provides DW DMA controller to perform low-speed peripherals
> > Mem-to-Dev and Dev-to-Mem transaction. This is also applicable to the DW
> > APB SSI devices embedded into the SoC. Currently this type DMA device is
>
> This basically all looks good to me (without any hardware specific
> knowledge), I had a few comments but they were mostly procedural ones -
> mainly getting these bug fixes you've done merged as such. Nice work.

Agree that is nice work!
Though, can you please give us chance to review next version of the series and test on our hardware?

Serge, I think you should base it on spi/for-next rather than vanilla.

--
With Best Regards,
Andy Shevchenko