Re: [PATCH] efi: Replace zero-length array with flexible-array

From: Gustavo A. R. Silva
Date: Fri May 08 2020 - 19:37:17 EST


On Fri, May 08, 2020 at 10:26:40AM -0700, Linus Torvalds wrote:
> On Thu, May 7, 2020 at 12:22 PM Gustavo A. R. Silva
> <gustavoars@xxxxxxxxxx> wrote:
> >
> > The current codebase makes use of the zero-length array language
> > extension to the C90 standard, but the preferred mechanism to declare
> > variable-length types such as these ones is a flexible array member[1][2],
> > introduced in C99 [...]
>
> Why is this called an "efi" patch, when it doesn't appear to be so at all:
>
> > include/linux/dma/ti-cppi5.h | 4 ++--
> > include/linux/efi.h | 2 +-
> > include/linux/mailbox/zynqmp-ipi-message.h | 2 +-
> > include/linux/platform_data/cros_ec_commands.h | 4 ++--
> > include/linux/platform_data/cros_ec_proto.h | 2 +-
> > kernel/params.c | 2 +-
> > kernel/tracepoint.c | 2 +-
> > scripts/kallsyms.c | 2 +-
> > 8 files changed, 10 insertions(+), 10 deletions(-)
>
> Yes, one line of the patch is EFI code. The rest are not.
>

Yeah. It seems the script needs some improvement. I'll split this
patch up into multiple patches.

Thanks
--
Gustavo