Re: [PATCH][V2] net: tg3: tidy up loop, remove need to compute off with a multiply

From: Jakub Kicinski
Date: Sat May 09 2020 - 01:49:12 EST


On Sat, 9 May 2020 00:14:47 +0100 Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently the value for 'off' is computed using a multiplication and
> a couple of statements later off is being incremented by len and
> this value is never read. Clean up the code by removing the
> multiplication and just increment off by len on each iteration.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied, thank you!