Re: [PATCH] power: reset: ltc2952: remove set variable but unused value

From: Markus Elfring
Date: Sat May 09 2020 - 03:03:09 EST


> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/power/reset/ltc2952-poweroff.c:97:16: warning: variable
> âoverrunsâ set but not used [-Wunused-but-set-variable]

I suggest to improve also this commit message.

* Can it be helpful to replace the word âFixesâ by the text
âAn issue was pointed out by the compiler.â?

* How do you think about to add the wording âThus delete the mentioned variable.â
to the change description?

* The value of an assigned variable was not reused in this function implementation.
Should this detail be better represented in the final commit subject?

* Would you like to add the tag âFixesâ?

Regards,
Markus