Re: [PATCH v6] Add mtk matrix keypad driver for keypad on MTK SoC
From: Marco Felsch
Date: Sat May 09 2020 - 05:39:32 EST
Hi Yu,
sorry if this is not your first name..
Something went wrong with you v6 since you are sending diffs to files
that are not present in input-master/next.
Regards,
Marco
On 20-05-09 10:04, Fengping Yu wrote:
> Change since v5:
> - remove unnecessary include files
> - remove redundant comments and newlines
> - use local irqnr variable instead of member variable of mtk_keypad struct
> - use regmap to read and write registers
> - drop kpd_get_dts_info directly into probe function
> - use devm_add_action_or_reset to avoid goto error handling when do clk setting
> - use devm_request_threaded_irq api to request irq
> - remove platform_set_drvdata
>
> fengping.yu (3):
> dt-bindings: Change keypad documentation schema
> drivers: input: keyboard: Add mtk keypad driver
> configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=y
>
> .../devicetree/bindings/input/mtk-kpd.txt | 61 -------
> .../devicetree/bindings/input/mtk-kpd.yaml | 93 +++++++++++
> arch/arm64/configs/defconfig | 1 +
> drivers/input/keyboard/Kconfig | 5 +-
> drivers/input/keyboard/mtk-kpd.c | 151 ++++++++----------
> 5 files changed, 163 insertions(+), 148 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txt
> create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml
>
> --
> 2.18.0
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |