Re: [patch V4 part 2 12/18] x86,objtool: Make entry_64_compat.S objtool clean

[Thomas Gleixner]

Andy Lutomirski <luto@xxxxxxxxxx> writes:

> On Tue, May 5, 2020 at 7:14 AM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>>
>> Currently entry_64_compat is exempt from objtool, but with vmlinux
>> mode there is no hiding it.
>>
>> Make the following changes to make it pass:
>>
>>  - change entry_SYSENTER_compat to STT_NOTYPE; it's not a function
>>    and doesn't have function type stack setup.
>>
>>  - mark all STT_NOTYPE symbols with UNWIND_HINT_EMPTY; so we do
>>    validate them and don't treat them as unreachable.
>>
>>  - don't abuse RSP as a temp register, this confuses objtool
>>    mightily as it (rightfully) thinks we're doing unspeakable
>>    things to the stack.
>>
>
> Acked-by: Andy Lutomirski <luto@xxxxxxxxxx>
>
>> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
>
> Did a From line get eaten?

Yes. A couple of patches which were just handed back and forth between
me and Peter lost them. Fixed them all up localy already.

Thanks,

        tglx