Re: [PATCH v4] streamline_config.pl: add LMC_KEEP to preserve some kconfigs

[Masahiro Yamada]

On Fri, May 8, 2020 at 11:00 PM Changbin Du <changbin.du@xxxxxxxxx> wrote:
>
> On Thu, May 07, 2020 at 09:18:07AM -0400, Steven Rostedt wrote:
> > On Thu, 7 May 2020 12:19:57 +0900
> > Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> >
> > > On Sun, May 3, 2020 at 9:11 AM Changbin Du <changbin.du@xxxxxxxxx> wrote:
> > > >
> > > > Sometimes it is useful to preserve batches of configs when making
> > > > localmodconfig. For example, I usually don't want any usb and fs
> > > > modules to be disabled. Now we can do it by:
> > > >
> > > >  $ make LMC_KEEP="drivers/usb;fs" localmodconfig
> > > >
> > > > Signed-off-by: Changbin Du <changbin.du@xxxxxxxxx>
> > > >
> > > > ---
> > > > v4: fix typo.
> > > > v3: rename LOCALMODCONFIG_PRESERVE to shorter LMC_KEEP.
> > > > v2: fix typo in documentation. (Randy Dunlap)
> > > > ---
> > >
> > >
> > > Personally, I do not mind the long LOCALMODCONFIG_PRESERVE,
> >
> > Perhasp we allow both? ;-)
> >
> > And just have one set to the other.
> >
> > > but this tends to be bike-sheding.
> > > I do not have a strong opinion.
> > >
> > >
> > > >  Documentation/admin-guide/README.rst |  8 +++++++-
> > > >  scripts/kconfig/Makefile             |  1 +
> > > >  scripts/kconfig/streamline_config.pl | 23 +++++++++++++++++++++++
> > > >  3 files changed, 31 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/Documentation/admin-guide/README.rst b/Documentation/admin-guide/README.rst
> > > > index cc6151fc0845..1371deab8bc7 100644
> > > > --- a/Documentation/admin-guide/README.rst
> > > > +++ b/Documentation/admin-guide/README.rst
> > > > @@ -209,10 +209,16 @@ Configuring the kernel
> > > >                             store the lsmod of that machine into a file
> > > >                             and pass it in as a LSMOD parameter.
> > > >
> > > > +                           Also, you can preserve modules in certain folders
> > > > +                           or kconfig files by specifying their paths in
> > > > +                           parameter LMC_KEEP.
> > > > +
> > > >                     target$ lsmod > /tmp/mylsmod
> > > >                     target$ scp /tmp/mylsmod host:/tmp
> > > >
> > > > -                   host$ make LSMOD=/tmp/mylsmod localmodconfig
> > > > +                   host$ make LSMOD=/tmp/mylsmod \
> > > > +                           LMC_KEEP="drivers/usb;drivers/gpu;fs" \
> > >
> > >
> > > This might be another bike-sheding item, but
> > > can you use a space for the delimiter?
> > >
> > >
> > > LMC_KEEP="drivers/usb drivers/gpu fs"
> > >
> > > If you pass multiple directories,
> > > you will need to surround them with double-quotes.
> >
> > I agree that spaces look better.
> >
> I am okay with space. But what about ":" which is used by shell PATH and many
> others?


I am not sure 'many others',
but you can pick what you like.





-- 
Best Regards
Masahiro Yamada