Re: [PATCH net-next 3/5] net: hns3: provide .get_cmdq_stat interface for the client

From: Jakub Kicinski
Date: Sat May 09 2020 - 16:48:23 EST


On Sat, 9 May 2020 17:27:39 +0800 Huazhong Tan wrote:
> This patch provides a new interface for the client to query
> whether CMDQ is ready to work.
>
> Signed-off-by: Huazhong Tan <tanhuazhong@xxxxxxxxxx>

> diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.h b/drivers/net/ethernet/hisilicon/hns3/hnae3.h
> index 5602bf2..7506cab 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hnae3.h
> +++ b/drivers/net/ethernet/hisilicon/hns3/hnae3.h
> @@ -552,6 +552,7 @@ struct hnae3_ae_ops {
> int (*set_vf_mac)(struct hnae3_handle *handle, int vf, u8 *p);
> int (*get_module_eeprom)(struct hnae3_handle *handle, u32 offset,
> u32 len, u8 *data);
> + bool (*get_cmdq_stat)(struct hnae3_handle *handle);
> };

I don't see anything in this series using this new interface, why is it
added now?