Re: [PATCH v5 1/9] w1_therm: adding code comments and code reordering

[Akira shimahara]

Le samedi 09 mai 2020 Ã 19:26 -0700, Randy Dunlap a Ãcrit :
> > +
> > +/*----------------------------------Structs-----------------------
> > ----------*/
> > +
> > +/**
> > + * struct w1_therm_family_converter
> > + * \brief Used to bind standard function call
> > + * to device specific function
> > + * it could be routed to NULL if device don't support feature
> > + */
> 
> 
> Hi,
> 
> 
> 
> All of the struct and function documentation comments in all patches
> in
> 
> this patch series should be using kernel-doc notation instead of the
> above
> 
> (whatever it is; I don't know what it is).
> 
> 
> 
> 
> 
> > +struct w1_therm_family_converter {
> > +     u8              broken;
> > +     u16             reserved;
> > +     struct w1_family        *f;
> > +     int             (*convert)(u8 rom[9]);
> > +     int             (*precision)(struct device *device, int val);
> > +     int             (*eeprom)(struct device *device);
> > +};
> > +
> 
> 
> thanks.
> 
> --
> 
> ~Randy

Hi,

Well noted, I will do it and re submit the serie. Thanks for your time.

Akira SHIMAHARA