Re: net/sonic: Fix some resource leaks in error handling paths

From: Markus Elfring
Date: Sun May 10 2020 - 05:07:46 EST


>> https://lore.kernel.org/lkml/20200427061803.53857-1-christophe.jaillet@xxxxxxxxxx/
>
> Do you know when these bugs were introduced?

I suggest to take another look at a provided tag âFixesâ.
To which commit would you like to refer to for the proposed adjustment of
the function âmac_sonic_platform_probeâ?


> Naming goto labels is just painting another bikeshed. Yes, some
> alternatives are preferable but it takes too long to identify them and
> finding consensus is unlikely anyway, as it's a matter of taste.

Would you find numbered labels unwanted according to a possible interpretation
related to âGW-BASICâ identifier selection?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=e99332e7b4cda6e60f5b5916cf9943a79dbef902#n460

Can programming preferences evolve into the direction of âsay what the goto doesâ?

Regards,
Markus