Re: [PATCH v4 00/10] add STM32 FMC2 EBI controller driver

[Christophe Kerello]

Hi Miquel,

On 5/11/20 11:22 AM, Miquel Raynal wrote:
> Hi Christophe,
>
> Christophe Kerello <christophe.kerello@xxxxxx> wrote on Wed, 6 May 2020
> 11:11:09 +0200:
>
> > The FMC2 functional block makes the interface with: synchronous and
> > asynchronous static devices (such as PSNOR, PSRAM or other memory-mapped
> > peripherals) and NAND flash memories.
> > Its main purposes are:
> >    - to translate AXI transactions into the appropriate external device
> >      protocol
> >    - to meet the access time requirements of the external devices
> > All external devices share the addresses, data and control signals with the
> > controller. Each external device is accessed by means of a unique Chip
> > Select. The FMC2 performs only one access at a time to an external device.
> >
> > Changes in v4:
> >   - bindings:
> >     - fix filename: st,stm32-fmc2-ebi.yaml
> >
> > Changes in v3:
> >   - NAND:
> >     - rename labels used on errors
> >     - add in the commit log the reason to increase FMC2_TIMEOUT_MS (patch 3)
> >     - add Miquel reviewed-by tag (patches 2/4/5/9)
> >   - EBI:
> >     - move in memory folder
> >     - merge MFD and BUS drivers to avoid a MFD driver
> >   - bindings:
> >     - pattern name has been modified
> >     - vendor properties have been modified
> >       - s/_/-/
> >       - add unit suffix (-ns) on timing properties
> >
> > Christophe Kerello (10):
> >    mtd: rawnand: stm32_fmc2: manage all errors cases at probe time
> >    mtd: rawnand: stm32_fmc2: remove useless inline comments
> >    mtd: rawnand: stm32_fmc2: use FMC2_TIMEOUT_MS for timeouts
> >    mtd: rawnand: stm32_fmc2: cleanup
> >    mtd: rawnand: stm32_fmc2: use FIELD_PREP/FIELD_GET macros
> >    dt-bindings: mtd: update STM32 FMC2 NAND controller documentation
> >    dt-bindings: memory-controller: add STM32 FMC2 EBI controller
> >      documentation
> >    memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver
> >    mtd: rawnand: stm32_fmc2: use regmap APIs
> >    mtd: rawnand: stm32_fmc2: get resources from parent node
> >
> >   .../memory-controllers/st,stm32-fmc2-ebi.yaml      |  261 +++++
> >   .../bindings/mtd/st,stm32-fmc2-nand.yaml           |   19 +-
> >   drivers/memory/Kconfig                             |   10 +
> >   drivers/memory/Makefile                            |    1 +
> >   drivers/memory/stm32-fmc2-ebi.c                    | 1206 ++++++++++++++++++++
> >   drivers/mtd/nand/raw/Kconfig                       |    1 +
> >   drivers/mtd/nand/raw/stm32_fmc2_nand.c             | 1176 ++++++++++---------
> >   7 files changed, 2061 insertions(+), 613 deletions(-)
> >   create mode 100644 Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
> >   create mode 100644 drivers/memory/stm32-fmc2-ebi.c
>
> I'm fine with the preparation patches 1-5 but the other patches need
> Rob's hack and probably more changes. If it's fine with you I can apply
> these patches for the next merge window and let more time to work on
> the last 5.

I am fine with your proposal.

Regards,
Christophe Kerello.

> Thanks,
> MiquÃl