Re: [v2 4/4] regulator: qcom: labibb: Add SC interrupt handling

[Mark Brown]

On Sat, May 09, 2020 at 02:12:00AM +0530, Sumit Semwal wrote:

> +static irqreturn_t labibb_sc_err_handler(int irq, void *_reg)
> +{
> +	int ret, count;
> +	u16 reg;
> +	u8 sc_err_mask;
> +	unsigned int val;
> +	struct labibb_regulator *labibb_reg = (struct labibb_regulator *)_reg;
> +	bool in_sc_err, reg_en, scp_done = false;
> +
> +	if (irq == labibb_reg->sc_irq)
> +		reg = labibb_reg->base + REG_LABIBB_STATUS1;
> +	else
> +		return IRQ_HANDLED;

Why would we be registering the interrupt handler when it's not valid?

Attachment: signature.asc
Description: PGP signature