Re: [PATCH 2/2] nouveau: fix dependencies for DEVICE_PRIVATE
From: Jason Gunthorpe
Date: Mon May 11 2020 - 09:53:07 EST
On Fri, May 08, 2020 at 04:40:09PM +0200, Arnd Bergmann wrote:
> CONFIG_DEVICE_PRIVATE cannot be selected in configurations
> without ZONE_DEVICE:
>
> WARNING: unmet direct dependencies detected for DEVICE_PRIVATE
> Depends on [n]: ZONE_DEVICE [=n]
> Selected by [y]:
> - DRM_NOUVEAU_SVM [=y] && HAS_IOMEM [=y] && DRM_NOUVEAU [=y] && MMU [=y] && STAGING [=y]
> kernel/resource.c:1653:28: error: use of undeclared identifier 'PA_SECTION_SHIFT'
> size = ALIGN(size, 1UL << PA_SECTION_SHIFT);
> ^
> kernel/resource.c:1654:48: error: use of undeclared identifier 'MAX_PHYSMEM_BITS'
>
> Add a dependency for Nouveau to avoid broken randconfig builds.
>
> Fixes: d2c63df2242e ("mm/hmm: make CONFIG_DEVICE_PRIVATE into a
> select")
I've reverted the patch this fixes, it seems more trouble than it is
worth.
Thanks,
Jason