Re: [PATCH v4 2/2] Documentation/sysctl: Document uclamp sysctl knobs

From: Qais Yousef
Date: Mon May 11 2020 - 11:28:57 EST


Hi Patrick

On 05/11/20 15:00, Patrick Bellasi wrote:

[...]

> > I have this now
> >
> > """
> > 984 This knob will not escape the range constraint imposed by sched_util_clamp_min
> > 985 defined above.
> > 986
> > 987 For example if
> > 988
> > 989 sched_util_clamp_min_rt_default = 800
> > 990 sched_util_clamp_min = 600
> > 991
> > 992 Then the boost will be clamped to 600 because 800 is outside of the permissible
> > 993 range of [0:600]. This could happen for instance if a powersave mode will
> > 994 restrict all boosts temporarily by modifying sched_util_clamp_min. As soon as
> > 995 this restriction is lifted, the requested sched_util_clamp_min_rt_default
> > 996 will take effect.
> > 997
> > 998 Any modification is applied lazily to currently running tasks and should be
> > 999 visible by the next wakeup.
> > """
>
> That's better IMHO, would just slightly change the last sentence to:
>
> Any modification is applied lazily to tasks and is effective
> starting from their next wakeup.

+1, will post v5 later today.

Thanks

--
Qais Yousef