Re: [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml

[Dan Murphy]

Andrew

On 5/11/20 10:22 AM, Andrew F. Davis wrote:
> On 5/7/20 2:30 PM, Dan Murphy wrote:
> > Convert the bq27xxx.txt to yaml format
> >
> > CC: Pali RohÃr <pali@xxxxxxxxxx>
> > CC: Andrew F. Davis <afd@xxxxxx>
> > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > ---
> >   .../bindings/power/supply/bq27xxx.txt         | 56 ------------
> >   .../bindings/power/supply/bq27xxx.yaml        | 86 +++++++++++++++++++
> >   2 files changed, 86 insertions(+), 56 deletions(-)
> >   delete mode 100644 Documentation/devicetree/bindings/power/supply/bq27xxx.txt
> >   create mode 100644 Documentation/devicetree/bindings/power/supply/bq27xxx.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/bq27xxx.txt b/Documentation/devicetree/bindings/power/supply/bq27xxx.txt
> > deleted file mode 100644
> > index 4fa8e08df2b6..000000000000
> > --- a/Documentation/devicetree/bindings/power/supply/bq27xxx.txt
> > +++ /dev/null
> > @@ -1,56 +0,0 @@
> > -TI BQ27XXX fuel gauge family
> > -
> > -Required properties:
> > -- compatible: contains one of the following:
> > - * "ti,bq27200" - BQ27200
> > - * "ti,bq27210" - BQ27210
> > - * "ti,bq27500" - deprecated, use revision specific property below
> > - * "ti,bq27510" - deprecated, use revision specific property below
> > - * "ti,bq27520" - deprecated, use revision specific property below
> > - * "ti,bq27500-1" - BQ27500/1
>
> This doesn't look right, these are two parts, we should be specific in
> DT, so:
>
> ti,bq27500
> ti,bq27501
>
> should be separate like that.

I agree if they are 2 different parts but the code has

ÂÂÂ { .compatible = "ti,bq27500-1" },

But it has no consumers.

So the ti,bq27500-1 compatible should be deprecated and ti,bq27501Â 
should be added and the ti,bq27500 should be reinstated.

Dan