Re: [PATCH v4 07/12] kgdboc: Remove useless #ifdef CONFIG_KGDB_SERIAL_CONSOLE in kgdboc

[Daniel Thompson]

On Thu, May 07, 2020 at 01:08:45PM -0700, Douglas Anderson wrote:
> This file is only ever compiled if that config is on since the
> Makefile says:
> 
>   obj-$(CONFIG_KGDB_SERIAL_CONSOLE) += kgdboc.o
> 
> Let's get rid of the useless #ifdef.
> 
> Reported-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>


> ---
> 
> Changes in v4:
> - ("kgdboc: Remove useless #ifdef...") new for v4.
> 
> Changes in v3: None
> Changes in v2: None
> 
>  drivers/tty/serial/kgdboc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c
> index 519d8cfbfbed..2e9158fff976 100644
> --- a/drivers/tty/serial/kgdboc.c
> +++ b/drivers/tty/serial/kgdboc.c
> @@ -380,7 +380,6 @@ static struct kgdb_io kgdboc_io_ops = {
>  	.post_exception		= kgdboc_post_exp_handler,
>  };
>  
> -#ifdef CONFIG_KGDB_SERIAL_CONSOLE
>  static int kgdboc_option_setup(char *opt)
>  {
>  	if (!opt) {
> @@ -409,7 +408,6 @@ static int __init kgdboc_early_init(char *opt)
>  }
>  
>  early_param("ekgdboc", kgdboc_early_init);
> -#endif /* CONFIG_KGDB_SERIAL_CONSOLE */
>  
>  module_init(init_kgdboc);
>  module_exit(exit_kgdboc);
> -- 
> 2.26.2.645.ge9eca65c58-goog
>