Re: [PATCH v1] ASoC: rsnd: add interrupt support for SSI BUSIF buffer

From: Mark Brown
Date: Mon May 11 2020 - 12:07:36 EST


On Mon, May 11, 2020 at 06:04:15PM +0800, Yongbo Zhang wrote:
> SSI BUSIF buffer is possible to overflow or underflow, especially in a
> hypervisor environment. If there is no interrupt support, it will eventually
> lead to errors in pcm data.
> This patch adds overflow and underflow interrupt support for SSI BUSIF buffer.

This introduces loads of build errors on for-5.8 with an x86
allmodconfig:

/mnt/kernel/sound/soc/sh/rcar/ssi.c: In function 'rsnd_ssi_quit':
/mnt/kernel/sound/soc/sh/rcar/ssi.c:596:12: error: invalid storage class for function 'rsnd_ssi_hw_params'
static int rsnd_ssi_hw_params(struct rsnd_mod *mod,
^~~~~~~~~~~~~~~~~~
/mnt/kernel/sound/soc/sh/rcar/ssi.c:596:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
static int rsnd_ssi_hw_params(struct rsnd_mod *mod,
^~~~~~

and so on for ages. Probably just needs a rebase I guess?

Attachment: signature.asc
Description: PGP signature