Re: [PATCH 1/3] nand: brcmnand: rename v4 registers

[Miquel Raynal]

Hi Ãlvaro,

Ãlvaro FernÃndez Rojas <noltari@xxxxxxxxx> wrote on Sun, 10 May 2020
17:14:04 +0200:

> These registers are also used on v3.3.
> 
> Signed-off-by: Ãlvaro FernÃndez Rojas <noltari@xxxxxxxxx>
> ---
>  drivers/mtd/nand/raw/brcmnand/brcmnand.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> index e4e3ceeac38f..6a08dd07b058 100644
> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> @@ -338,8 +338,8 @@ enum brcmnand_reg {
>  	BRCMNAND_FC_BASE,
>  };
>  
> -/* BRCMNAND v4.0 */
> -static const u16 brcmnand_regs_v40[] = {
> +/* BRCMNAND v3.3-v4.0 */
> +static const u16 brcmnand_regs_v33[] = {
>  	[BRCMNAND_CMD_START]		=  0x04,
>  	[BRCMNAND_CMD_EXT_ADDRESS]	=  0x08,
>  	[BRCMNAND_CMD_ADDRESS]		=  0x0c,
> @@ -591,8 +591,8 @@ static int brcmnand_revision_init(struct brcmnand_controller *ctrl)
>  		ctrl->reg_offsets = brcmnand_regs_v60;
>  	else if (ctrl->nand_version >= 0x0500)
>  		ctrl->reg_offsets = brcmnand_regs_v50;
> -	else if (ctrl->nand_version >= 0x0400)
> -		ctrl->reg_offsets = brcmnand_regs_v40;
> +	else if (ctrl->nand_version >= 0x0303)
> +		ctrl->reg_offsets = brcmnand_regs_v33;
>  
>  	/* Chip-select stride */
>  	if (ctrl->nand_version >= 0x0701)

Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>