RE: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init

[Alim Akhtar]

Hello Krzysztof,
Thanks for the patch.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 11 May 2020 14:04
> To: Jonathan Cameron <jic23@xxxxxxxxxx>; Hartmut Knaack
> <knaack.h@xxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; Peter Meerwald-
> Stadler <pmeerw@xxxxxxxxxx>; Kukjin Kim <kgene@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzk@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
> 
> The Exynos7-specific code bits in ADC driver do not play with PHY:
> the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data
> instance.  Therefore the initialization code does not have to check if it
is true.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> 
Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
Tested on exynos7-espresso board so,
Tested-by:  Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> ---
> 
> Only build tested.
> ---
>  drivers/iio/adc/exynos_adc.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index
> 22131a677445..219c8eb32d16 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct
> exynos_adc *info)  {
>  	u32 con1, con2;
> 
> -	if (info->data->needs_adc_phy)
> -		regmap_write(info->pmu_map, info->data->phy_offset, 1);
> -
>  	con1 = ADC_V2_CON1_SOFT_RESET;
>  	writel(con1, ADC_V2_CON1(info->regs));
> 
> --
> 2.17.1