Re: [PATCH 2/2] slimbus: core: Fix mismatch in of_node_get/put

[Saravana Kannan]

On Mon, May 11, 2020 at 8:13 AM Srinivas Kandagatla
<srinivas.kandagatla@xxxxxxxxxx> wrote:
>
> From: Saravana Kannan <saravanak@xxxxxxxxxx>
>
> Adding missing corresponding of_node_put
>
> Fixes: 7588a511bdb4 ("slimbus: core: add support to device tree helper")
> Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
> [Srini: added fixes tag, removed NULL check and updated log]
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> ---
>  drivers/slimbus/core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
> index 1f3beee74fdf..ae1e248a8fb8 100644
> --- a/drivers/slimbus/core.c
> +++ b/drivers/slimbus/core.c
> @@ -282,6 +282,7 @@ EXPORT_SYMBOL_GPL(slim_register_controller);
>  /* slim_remove_device: Remove the effect of slim_add_device() */
>  static void slim_remove_device(struct slim_device *sbdev)
>  {
> +       of_node_put(sbdev->dev.of_node);
>         device_unregister(&sbdev->dev);
>  }
>

The edits look fine to me.

-Saravana