Re: [PATCHv3 42/50] xtensa: Add loglvl to show_trace()

[Dmitry Safonov]

Hi Mike,

On 5/11/20 8:45 PM, Mike Rapoport wrote:
[..]
>> @@ -511,7 +515,7 @@ void show_stack(struct task_struct *task, unsigned long *sp)
>>  	print_hex_dump(KERN_INFO, " ", DUMP_PREFIX_NONE,
>>  		       STACK_DUMP_LINE_SIZE, STACK_DUMP_ENTRY_SIZE,
>>  		       sp, len, false);
>> -	show_trace(task, sp);
>> +	show_trace(task, stack, KERN_INFO);
> 
> it should have been
> 
> 	show_trace(task, sp, KERN_INFO);

Thank you for noticing it!

> 
> Andrew, can you fold the following patch as a fixup please:
> 
> 
> diff --git a/arch/xtensa/kernel/traps.c b/arch/xtensa/kernel/traps.c
> index f9217b6b45c8..efc3a29cde80 100644
> --- a/arch/xtensa/kernel/traps.c
> +++ b/arch/xtensa/kernel/traps.c
> @@ -515,7 +515,7 @@ void show_stack(struct task_struct *task, unsigned long *sp, const char *loglvl)
>  	print_hex_dump(loglvl, " ", DUMP_PREFIX_NONE,
>  		       STACK_DUMP_LINE_SIZE, STACK_DUMP_ENTRY_SIZE,
>  		       sp, len, false);
> -	show_trace(task, stack, loglvl);
> +	show_trace(task, sp, loglvl);
>  }
>  
>  DEFINE_SPINLOCK(die_lock);
> 

Thanks,
          Dmitry