Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting

From: Andrew Lunn
Date: Mon May 11 2020 - 20:47:24 EST


On Mon, May 11, 2020 at 05:24:07PM -0700, Doug Berger wrote:
> A comment in uapi/linux/ethtool.h states "Drivers should reject a
> non-zero setting of @autoneg when autoneogotiation is disabled (or
> not supported) for the link".
>
> That check should be added to phy_validate_pause() to consolidate
> the code where possible.
>
> Fixes: 22b7d29926b5 ("net: ethernet: Add helper to determine if pause configuration is supported")

Hi Doug

If this is a real fix, please submit this to net, not net-next.

Andrew