Re: [RFC PATCH 4/4] dt-bindings: net: phy: extend dt binding for VSC8541 ethernet-phy

From: Rob Herring
Date: Mon May 11 2020 - 22:12:08 EST


On Tue, Apr 28, 2020 at 04:16:48AM -0700, Sagar Shrikant Kadam wrote:
> Adding a OUI (Organizationally Unique Identifier) for VSC8541-01
> device to dt node requires a corresponding dt-binding entry as well
> so that checkpatch doesn't complain with a warning:
>
> DT compatible string "ethernet-phy-id0007.0771" appears un-documented
>
> Here extend the existing dt binding of VSC8531 device to include
> VSC8541 device example.

Checkpatch.pl is just dumb here and can be ignored. We have the regex
that documents this compatible. We don't need every VID/PID listed.

>
> Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> index 5ff37c6..774448a 100644
> --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> @@ -68,3 +68,6 @@ Example:
> vsc8531,led-0-mode = <LINK_1000_ACTIVITY>;
> vsc8531,led-1-mode = <LINK_100_ACTIVITY>;
> };
> + vsc8541_0: ethernet-phy@0 {
> + compatible = "ethernet-phy-id0007.0771";
> + };
> --
> 2.7.4
>