Re: [PATCH v4 04/10] mtd: rawnand: stm32_fmc2: cleanup

From: Christophe Kerello
Date: Tue May 12 2020 - 02:50:24 EST


Hi Miquel,

On 5/11/20 10:39 PM, Miquel Raynal wrote:

Christophe Kerello <christophe.kerello@xxxxxx> wrote on Wed, 6 May 2020
11:11:13 +0200:

This patch renames functions and local variables.
This cleanup is done to get all functions starting by stm32_fmc2_nfc
in the FMC2 raw NAND driver when all functions will start by
stm32_fmc2_ebi in the FMC2 EBI driver.

Signed-off-by: Christophe Kerello <christophe.kerello@xxxxxx>
Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

Applied to nand/next as well but for an unknown reason I had to do it
by hand because the patch would not apply.

Thanks,
MiquÃl

This is strange, I can apply this patch on my tree without any conflicts.
There is a compilation issue line 1301.

@@ -1302,44 +1298,45 @@ static void stm32_fmc2_write_data(struct nand_chip *chip, const void *buf,

if (force_8bit && chip->options & NAND_BUSWIDTH_16)
/* Reconfigure bus width to 16-bit */
- stm32_fmc2_set_buswidth_16(fmc2, true);
+ stm32_fmc2_nfc_set_buswidth_16(nfc, true);
}

I will rebase on top of nand/next today to check that there is no issues with the driver.

Regards,
Christophe Kerello.