Re: [RFC PATCH v2 1/7] block: Extand commit_rqs() to do batch processing

From: Ming Lei
Date: Tue May 12 2020 - 03:55:24 EST


On Mon, May 11, 2020 at 11:26:07PM -0700, Sagi Grimberg wrote:
>
> > > devices will benefit from the batching so maybe the flag needs to be
> > > inverted? BLK_MQ_F_DONT_BATCHING_SUBMISSION?
> >
> > Actually I'd rather to not add any flag, and we may use some algorithm
> > (maybe EWMA or other intelligent stuff, or use hctx->dispatch_busy directly)
> > to figure out one dynamic batching number which is used to dequeue requests
> > from scheduler or sw queue.
> >
> > Then just one single dispatch io code path is enough.
>
> Sounds good to me, do you plan to submit a patchset?
>

Yeah, I am working on that.


Thanks,
Ming