Re: [PATCH v2] memory/samsung: reduce unnecessary mutex lock area

From: Markus Elfring
Date: Tue May 12 2020 - 07:41:22 EST


> Maybe dmc->df->lock seems not needed to protect "if (ret)
> & dev_warn" branch. Maybe this change speed up the code a bit.

I suggest to improve also this commit message.

* Please reduce uncertainty.

* An imperative wording is probably preferred, isn't it?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=152036d1379ffd6985262743dcf6b0f9c75f83a4#n151

* Will it be more appropriate to refer to the transformation âReduce the lock scopeâ?

* Would you like to add the tag âFixesâ to the change description?

Regards,
Markus