Re: [PATCH v3 1/3] arch/x86: Rename config X86_INTEL_MEMORY_PROTECTION_KEYS to generic x86

[Babu Moger]

On 5/12/20 10:19 AM, Dave Hansen wrote:
> On 5/12/20 7:57 AM, Babu Moger wrote:
>>> I was hoping to see at least *some* justification in this changelog.  Do
>>> you think having "INTEL_" will confuse users?  Is there some technical
>>> merit to this change?
>>>
>>> The naming churn is an obviously bad, not technically necessary change.
>> Yes. Technically not necessary. But can cause some confusion on non-intel
>> platforms.
> 
> Seriously, guys, this is buried deep in kernel code.  Who is this confusing?
> 
> To me, this is like anything else we rename in the kernel.  It causes
> churn, which makes patches harder to backport for instance.  That's why
> we don't rename things willy-nilly when we just don't like the names.
> 
> The naming has to cause some practical, real-world problem that we *FIX*
> with the rename.
> 
> I'm just asking for a concrete, practical problem statement in the
> changelog.  If there isn't one, then please don't do the rename.  The
> Kconfig magic is still fine since it fixes a practical problem for end
> users.
> 

Alright. Alright. I will just keep Kconfig magic and update the
documentation(protection-keys.rst). Thanks