Re: [PATCH] mtd: offset align to block size bofore block operation

From: Kees Cook
Date: Tue May 12 2020 - 12:33:09 EST


On Tue, May 12, 2020 at 02:58:35PM +0800, WeiXiong Liao wrote:
> The off parameter on mtdpsore_block_*() does not align to block size,
> which makes some bugs. For example, a block contains dmesg zones
> with number 0 to 3. When user remove all these files, mapped to
> these zones, mtdpstore is expected to check whether No.0 to No.3 is
> unused then erase this block. However it check No.3 to No.6 because
> it get wrongly beginning zonenum from misaligned off.
>
> Signed-off-by: WeiXiong Liao <liaoweixiong@xxxxxxxxxxxxxxxxx>

Thanks! I've squashed this and will send a v8 of the mtdpstore
separately.

-Kees

--
Kees Cook