Re: [PATCH v2 2/7] dt-bindings: watchdog: dw-wdt: Support devices with asynch clocks

From: Serge Semin
Date: Tue May 12 2020 - 13:16:48 EST


Hello Sergei

On Mon, May 11, 2020 at 11:28:00AM +0300, Sergei Shtylyov wrote:
> On 11.05.2020 11:25, Sergei Shtylyov wrote:
>
> > > DW Watchdog IP core can be synthesised with asynchronous timer/APB
> > > clocks support (WDT_ASYNC_CLK_MODE_ENABLE == 1). In this case
> > > a separate clock signal is supposed to be used to feed watchdog timer
> > > and APB interface of the device. Lets along with the watchdog timer
> >                                        ^ verb missing? or comma?
>
> Oh, and probably "Let's" too. :-)
>
> >
> > > reference clock expect to have the optional APB3 bu interface clock
> > > sepcified in a DW WDT dt node.
> >
> >    Specified.

Thanks for noticing this. I'll just change the sentence to: "Let's update
the DW Watchdog DT node schema so it would support the optional APB3 bus
clock specified along with the mandatory watchdog timer reference clock."

-Sergey

> >
> > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> > > Cc: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx>
> > > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> > > Cc: Paul Burton <paulburton@xxxxxxxxxx>
> > > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> > > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > > Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > > Cc: linux-mips@xxxxxxxxxxxxxxx
> > [...]
>
> MBR, Sergei