Re: [PATCH 5/5] arm64: perf: Add cap_user_time_short

From: kbuild test robot
Date: Tue May 12 2020 - 13:44:55 EST


Hi Peter,

I love your patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[also build test ERROR on arm64/for-next/core arm-perf/for-next/perf linus/master v5.7-rc5 next-20200512]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Peter-Zijlstra/arm64-perf-Proper-cap_user_time-support/20200512-205141
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 059c6d68cfc5f85ba3ab71d71a6de380016f7936
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

arch/arm64/kernel/perf_event.c: In function 'arch_perf_update_userpage':
>> arch/arm64/kernel/perf_event.c:1187:11: error: 'struct perf_event_mmap_page' has no member named 'time_cycle'; did you mean 'time_cycles'?
1187 | userpg->time_cycle = rd->epoch_cyc;
| ^~~~~~~~~~
| time_cycles
arch/arm64/kernel/perf_event.c:1207:12: error: 'struct perf_event_mmap_page' has no member named 'shift'
1207 | if (userpg->shift == 32) {
| ^~
arch/arm64/kernel/perf_event.c:1208:9: error: 'struct perf_event_mmap_page' has no member named 'shift'
1208 | userpg->shift = 31;
| ^~

vim +1187 arch/arm64/kernel/perf_event.c

1167
1168 void arch_perf_update_userpage(struct perf_event *event,
1169 struct perf_event_mmap_page *userpg, u64 now)
1170 {
1171 struct clock_read_data *rd;
1172 unsigned int seq;
1173
1174 userpg->cap_user_time = 0;
1175 userpg->cap_user_time_zero = 0;
1176 userpg->cap_user_time_short = 0;
1177
1178 do {
1179 rd = sched_clock_read_begin(&seq);
1180
1181 if (rd->read_sched_clock != arch_timer_read_counter)
1182 return;
1183
1184 userpg->time_mult = rd->mult;
1185 userpg->time_shift = rd->shift;
1186 userpg->time_zero = rd->epoch_ns;
> 1187 userpg->time_cycle = rd->epoch_cyc;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip