Re: [PATCH 2/4] dt-bindings: sram: add documentation for reserved-only flag

From: Stephen Warren
Date: Tue May 12 2020 - 15:45:35 EST


On 5/12/20 8:48 AM, Mian Yousaf Kaukab wrote:
> Add documentation for the new optional flag added for SRAM driver.

> diff --git a/Documentation/devicetree/bindings/sram/sram.yaml b/Documentation/devicetree/bindings/sram/sram.yaml

> + reserved-only:
> + description:
> + The flag indicating, that only SRAM reserved regions have to be remapped.
> + remapping type is selected depending upon no-memory-wc as usual.
> + type: boolean

This feels a bit like a SW flag rather than a HW description, so I'm not
sure it's appropriate to put it into DT.

Are there any cases where the SW should map all of the SRAM, i.e. where
we wouldn't expect to set reserved-only? I'd expect reserved-only to be
the default, and perhaps only, mode of operation for the SRAM driver. If
we can't do that because some SW currently expects to be able to map
arbitrary portions of the SRAM, shouldn't that SW be fixed to tell the
SRAM driver which parts it's using, hence still allowing the driver to
only map in-use portions?