Re: [PATCH 2/2] gpio: Make "offset" and "unsigned int", not just "unsigned"

From: Andy Shevchenko
Date: Tue May 12 2020 - 17:09:24 EST


On Wed, Apr 29, 2020 at 3:40 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Tue, 2020-04-28 at 17:23 -0700, Douglas Anderson wrote:

...

> + int (*request)(struct gpio_chip *gc, unsigned int offset);
> + void (*free)(struct gpio_chip *gc, unsigned int offset);
> + int (*get_direction)(struct gpio_chip *gc, unsigned int offset);
> + int (*direction_input)(struct gpio_chip *gc, unsigned int offset);
> + int (*direction_output)(struct gpio_chip *gc,
> + unsigned int offset, int value);

Here...

> + int (*get)(struct gpio_chip *gc, unsigned int offset);
> + int (*get_multiple)(struct gpio_chip *gc,
> + unsigned long *mask, unsigned long *bits);
> + void (*set)(struct gpio_chip *gc, unsigned int offset, int value);
> + void (*set_multiple)(struct gpio_chip *gc,
> + unsigned long *mask, unsigned long *bits);
> + int (*set_config)(struct gpio_chip *gc,
> + unsigned int offset, unsigned long config);

...and here perhaps offset to move to previous line despite checkpatch warnings.

> + int (*to_irq)(struct gpio_chip *gc, unsigned int offset);
> + void (*dbg_show)(struct seq_file *s, struct gpio_chip *gc);
> + int (*init_valid_mask)(struct gpio_chip *gc,
> + unsigned long *valid_mask,
> + unsigned int ngpios);
> + int (*add_pin_ranges)(struct gpio_chip *gc);

--
With Best Regards,
Andy Shevchenko