Re: [PATCH v8 4/4] USB: pci-quirks: Add Raspberry Pi 4 quirk

From: Mathias Nyman
Date: Wed May 13 2020 - 03:02:40 EST


On 11.5.2020 17.25, Lorenzo Pieralisi wrote:
> On Tue, May 05, 2020 at 06:13:17PM +0200, Nicolas Saenz Julienne wrote:
>> On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be
>> loaded directly from an EEPROM or, if not present, by the SoC's
>> VideoCore. Inform VideoCore that VL805 was just reset.
>>
>> Also, as this creates a dependency between USB_PCI and VideoCore's
>> firmware interface, and since USB_PCI can't be set as a module neither
>> this can. Reflect that on the firmware interface Kconfg.
>>
>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>
>> ---
>>
>> Changes since v5:
>> - Fix Kconfig issue with allmodconfig
>>
>> Changes since v4:
>> - Do not split up error message
>>
>> Changes since v3:
>> - Add more complete error message
>>
>> Changes since v1:
>> - Make RASPBERRYPI_FIRMWARE dependent on this quirk to make sure it
>> gets compiled when needed.
>>
>> drivers/firmware/Kconfig | 3 ++-
>> drivers/usb/host/pci-quirks.c | 16 ++++++++++++++++
>> 2 files changed, 18 insertions(+), 1 deletion(-)
>
> Hi Mathias,
>
> I would need your ACK to merge this series, thanks.
>
> Lorenzo

Ah, yes, of course

Acked-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>