Re: [PATCH v5 1/7] fs: introduce kernel_pread_file* support

From: Scott Branden
Date: Wed May 13 2020 - 04:16:38 EST




On 2020-05-12 11:51 p.m., Greg Kroah-Hartman wrote:
On Tue, May 12, 2020 at 11:23:27PM -0700, Scott Branden wrote:
Hi Luis,

A few comments inline before I cleanup.

We do not export symbols when there are no in-kernel users.

Note: Existing kernel_read_file_from_path_initns is not used in the kernel.
Should we delete that as well?
Probably, yes.
I found drivers/base/firmware_loader calls kernel_read_file_from_path_initns so EXPORT_SYMBOL_GPL can stay there.
thanks,

greg k-h