Re: [PATCH v4 03/38] iommu: add generic helper for mapping sgtable objects

From: Joerg Roedel
Date: Wed May 13 2020 - 05:03:24 EST


Hi Marek,

On Tue, May 12, 2020 at 11:00:23AM +0200, Marek Szyprowski wrote:
> ---
> include/linux/iommu.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)

Some nits below, with those fixed:

Acked-by: Joerg Roedel <jroedel@xxxxxxx>

> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 7cfd2dd..ba662ba 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -478,6 +478,22 @@ extern size_t iommu_map_sg_atomic(struct iommu_domain *domain,
> extern void iommu_set_fault_handler(struct iommu_domain *domain,
> iommu_fault_handler_t handler, void *token);
>
> +/**
> + * iommu_map_sgtable - Map the given buffer to the IOMMU domain
> + * @domain: The IOMMU domain to perfor
^^^^^^ Truncated comment?
> + * @iova: The start addrees to map the buffer
^^^^^^^ Typo

> + * @sgt: The sg_table object describing the buffer
> + * @prot: IOMMU protection bits
> + *
> + * Create a mapping at @iova for the buffer described by a scatterlist
> + * stored in the given sg_table object in the provided IOMMU domain.
> + */
> +static inline size_t iommu_map_sgtable(struct iommu_domain *domain,
> + unsigned long iova, struct sg_table *sgt, int prot)
> +{
> + return iommu_map_sg(domain, iova, sgt->sgl, sgt->orig_nents, prot);
> +}
> +
> extern void iommu_get_resv_regions(struct device *dev, struct list_head *list);
> extern void iommu_put_resv_regions(struct device *dev, struct list_head *list);
> extern void generic_iommu_put_resv_regions(struct device *dev,
> --
> 1.9.1