Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

From: Mark Brown
Date: Wed May 13 2020 - 06:51:49 EST


On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote:

> Changes since V2:
> * Removed warn massage in max98390_dsm_calib_get func
> and add comment.

The problem isn't the warning, the problem is that you have an empty
operation. You should either implement the function (eg, by caching the
value written) or remove it and fix whatever problems you were running
into further up the stack when it's missing.

Attachment: signature.asc
Description: PGP signature