Re: [PATCH v2 3/6] irqchip: Add Loongson PCH PIC controller

[Thomas Gleixner]

Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> writes:
> +static void pch_pic_bitset(struct pch_pic *priv, int offset, int bit)
> +{
> +	void __iomem *addr = priv->base + offset + PIC_REG_IDX(bit) * 4;
> +	unsigned long flags;
> +	u32 reg;
> +
> +	raw_spin_lock_irqsave(&priv->pic_lock, flags);

See other reply.

> +	reg = readl(addr);
> +	reg |= BIT(PIC_REG_BIT(bit));
> +	writel(reg, addr);
> +	raw_spin_unlock_irqrestore(&priv->pic_lock, flags);
> +}
> +static int pch_pic_of_init(struct device_node *node,
> +				struct device_node *parent)
> +{
> +	struct pch_pic *priv;
> +	struct irq_domain *parent_domain;
> +	int err;

ordering

Thanks,

        tglx