Re: [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe()

[Tang Bin]

Hi gregkh:

On 2020/5/8 21:51, Alan Stern wrote:
> On Fri, 8 May 2020, Tang Bin wrote:
>
> > The function ehci_mxc_drv_probe() does not perform sufficient error
> > checking after executing platform_get_irq(), thus fix it.
> Aside from the "irq <= 0" issue, the Subject: line should say
> "ehci-mxc", not "ehci".
I know this patch need v2, whether just fix the subject?

Thanks,

Tang Bin

> > Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards")
> > Signed-off-by: Zhang Shengju <zhangshengju@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>
> > ---
> >   drivers/usb/host/ehci-mxc.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> > index a1eb5ee77..a0b42ba59 100644
> > --- a/drivers/usb/host/ehci-mxc.c
> > +++ b/drivers/usb/host/ehci-mxc.c
> > @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
> >   	}
> >   
> >   	irq = platform_get_irq(pdev, 0);
> > +	if (irq < 0)
> > +		return irq;
> >   
> >   	hcd = usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev));
> >   	if (!hcd)