Re: [PATCH] arm64: dts: qcom: disable the new cti nodes on devices with broken coresight

[Michael Srba]

On 13. 05. 20 18:04, Jeffrey Hugo wrote:
> On Wed, May 13, 2020 at 9:53 AM <michael.srba@xxxxxxxxx> wrote:
>> From: Michael Srba <michael.srba@xxxxxxxxx>
>>
>> Attempting to enable these devices causes a "synchronous
>> external abort". Suspected cause is that the debug power
>> domain is not enabled by default on this device.
>> Disable these devices for now to avoid the crash.
>>
>> See: https://lore.kernel.org/linux-arm-msm/20190618202623.GA53651@xxxxxxxxxxx/
>>
>> Fixes: b1fcc5702a41 ("arm64: dts: qcom: msm8916: Add CTI options")
>> Signed-off-by: Michael Srba <michael.srba@xxxxxxxxx>
>>
>> ---
>>  arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts       | 6 ++++++
>>  arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 6 ++++++
>>  2 files changed, 12 insertions(+)
> Why are we disabling these in board specific files?  Seems like these
> should be disabled in the base msm8916.dtsi.  Otherwise, the next
> board that gets brought up is probably going to hit this same exact
> issue.
>
> This also follows the solution that msm8998 did for the same issue.

I would also advocate for having them disabled by default. I *think* it was
brought up initially, but that would be before the msm8998 change.