Re: [PATCH] greybus: audio: remove unused code
From: Mark Greer
Date: Wed May 13 2020 - 13:45:35 EST
On Thu, May 07, 2020 at 11:29:11PM +0200, Alexandre Belloni wrote:
> GREYBUS_AUDIO_MSM8994 is not an existing configuration option and as
> reported in September 2016, it depends on an "out-of-tree qualcomm audio
> driver". This driver never made it upstream.
>
> https://lore.kernel.org/lkml/20160921073905.GA31263@xxxxxxxxx/
>
> Moreover, there doesn't seem to be any interest in actually fixing the
> driver as it uses ASoC APIs that have been removed from the kernel in 2018
> as shown by its use of snd_soc_register_codec and
> snd_soc_codec_get_drvdata, removed in commit 999f7f5af8eb ("ASoC: remove
> Codec related code").
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> ---
Everything you say is true but it is still kinda sad to see this go.
But that is life... If and when someone has the motivation to get this
working again they can take a look at the git history.
Thanks for this, Alexandre.
Acked-by: Mark Greer <mgreer@xxxxxxxxxxxxxxx>