Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support

From: Andrew Lunn
Date: Wed May 13 2020 - 14:01:51 EST


> What would be the best place to do a test before the link is getting up?
> Can it be done in the phy core, or it should be done in the PHY driver?
>
> So far, no action except of logging these errors is needed.

You could do it in the config_aneg callback.

A kernel log entry is not very easy to use. You might want to see how
easy it is to send a cable test result to userspace. Anything which is
interested in this information can then listen for it. All the needed
code is there, you will just need to rearrange it a bit.

Andrew