Re: [PATCH] drm/i915: Remove duplicate inline specifier on write_pte

From: Chris Wilson
Date: Wed May 13 2020 - 14:26:39 EST


Quoting Nathan Chancellor (2020-05-13 19:23:40)
> When building with clang:
>
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c:392:24: warning: duplicate
> 'inline' declaration specifier [-Wduplicate-decl-specifier]
> declaration specifier [-Wduplicate-decl-specifier]
> static __always_inline inline void
> ^
> include/linux/compiler_types.h:138:16: note: expanded from macro
> 'inline'
> #define inline inline __gnu_inline __inline_maybe_unused notrace
> ^
> 1 warning generated.
>
> __always_inline is defined as 'inline __attribute__((__always_inline))'
> so we do not need to specify it twice.
>
> Fixes: 84eac0c65940 ("drm/i915/gt: Force pte cacheline to main memory")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1024
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>

I forgot to ping Mika about this,
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris