Re: [PATCH v4] MIPS: Truncate link address into 32bit for 32bit kernel

[Maciej W. Rozycki]

On Mon, 13 Apr 2020, Jiaxun Yang wrote:

> > > diff --git a/arch/mips/kernel/vmlinux.lds.S
> > > b/arch/mips/kernel/vmlinux.lds.S index a5f00ec73ea6..5226cd8e4bee
> > > 100644 --- a/arch/mips/kernel/vmlinux.lds.S
> > > +++ b/arch/mips/kernel/vmlinux.lds.S
> > > @@ -55,7 +55,7 @@ SECTIONS
> > >  	/* . = 0xa800000000300000; */
> > >  	. = 0xffffffff80300000;
> > >  #endif
> > > -	. = VMLINUX_LOAD_ADDRESS;
> > > +	. = VMLINUX_LINK_ADDRESS;  
> > 
> >  The CONFIG_BOOT_ELF64 cruft right above it looks interesting to me,
> > never have ever been used.  We have had the current arrangement since:
> 
> It confused me either.
> It's only used by SGI so probably it's time to rename it as
> BOOT_SEG_ELF64.

 Well, as seen above the first assignment is immediately overridden by the 
second and the rest of the conditional are comments.  So as I say it's not 
used ever, not even any SGI configuration, and from Git history it looks 
like it has never been.

  Maciej