Re: [PATCH v2 2/2] powerpc/rtas: Implement reentrant rtas call

From: kbuild test robot
Date: Wed May 13 2020 - 18:33:02 EST


Hi Leonardo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.7-rc5 next-20200512]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Leonardo-Bras/powerpc-rtas-Move-type-struct-definitions-from-rtas-h-into-rtas-types-h/20200513-134244
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-randconfig-r004-20200513 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=powerpc64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

In file included from arch/powerpc/include/asm/paca.h:32,
from arch/powerpc/include/asm/current.h:13,
from include/linux/thread_info.h:21,
from include/asm-generic/preempt.h:5,
from ./arch/powerpc/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/compat.h:10,
from arch/powerpc/kernel/asm-offsets.c:14:
>> arch/powerpc/include/asm/rtas-types.h:20:2: error: unknown type name 'arch_spinlock_t'
20 | arch_spinlock_t lock;
| ^~~~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.build:100: arch/powerpc/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1141: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:180: sub-make] Error 2

vim +/arch_spinlock_t +20 arch/powerpc/include/asm/rtas-types.h

199960607a5af4 Leonardo Bras 2020-05-13 15
199960607a5af4 Leonardo Bras 2020-05-13 16 struct rtas_t {
199960607a5af4 Leonardo Bras 2020-05-13 17 unsigned long entry; /* physical address pointer */
199960607a5af4 Leonardo Bras 2020-05-13 18 unsigned long base; /* physical address pointer */
199960607a5af4 Leonardo Bras 2020-05-13 19 unsigned long size;
199960607a5af4 Leonardo Bras 2020-05-13 @20 arch_spinlock_t lock;
199960607a5af4 Leonardo Bras 2020-05-13 21 struct rtas_args args;
199960607a5af4 Leonardo Bras 2020-05-13 22 struct device_node *dev; /* virtual address pointer */
199960607a5af4 Leonardo Bras 2020-05-13 23 };
199960607a5af4 Leonardo Bras 2020-05-13 24

:::::: The code at line 20 was first introduced by commit
:::::: 199960607a5af4bbda685171c4fa70158829a647 powerpc/rtas: Move type/struct definitions from rtas.h into rtas-types.h

:::::: TO: Leonardo Bras <leobras.c@xxxxxxxxx>
:::::: CC: 0day robot <lkp@xxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip