Re: [patch V4 part 1 19/36] x86/entry: Exclude low level entry code from sanitizing

[Mathieu Desnoyers]

----- On May 6, 2020, at 12:03 PM, Alexandre Chartre alexandre.chartre@xxxxxxxxxx wrote:

> On 5/5/20 3:16 PM, Thomas Gleixner wrote:
>> The sanitizers are not really applicable to the fragile low level entry
>> code. code. Entry code needs to carefully setup a normal 'runtime'
> 
> typo: code. code.

Looking at updated tree, the reviewed-by is there, but there is still
way too much "code". ;)

Thanks,

Mathieu

> 
> Reviewed-by: Alexandre Chartre <alexandre.chartre@xxxxxxxxxx>
> 
> alex.
> 
> 
>> environment.
>> 
>> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
>> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> ---
>>   arch/x86/entry/Makefile |    8 ++++++++
>>   1 file changed, 8 insertions(+)
>> 
>> --- a/arch/x86/entry/Makefile
>> +++ b/arch/x86/entry/Makefile
>> @@ -3,6 +3,14 @@
>>   # Makefile for the x86 low level entry code
>>   #
>>   
>> +KASAN_SANITIZE := n
>> +UBSAN_SANITIZE := n
>> +KCOV_INSTRUMENT := n
>> +
>> +CFLAGS_REMOVE_common.o = $(CC_FLAGS_FTRACE) -fstack-protector
>> -fstack-protector-strong
>> +CFLAGS_REMOVE_syscall_32.o = $(CC_FLAGS_FTRACE) -fstack-protector
>> -fstack-protector-strong
>> +CFLAGS_REMOVE_syscall_64.o = $(CC_FLAGS_FTRACE) -fstack-protector
>> -fstack-protector-strong
>> +
>>   OBJECT_FILES_NON_STANDARD_entry_64_compat.o := y
>>   
>>   CFLAGS_syscall_64.o		+= $(call cc-option,-Wno-override-init,)

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com