Re: [PATCH -next] scsi: ufs-mediatek: Make ufs_mtk_fixup_dev_quirks static
From: Stanley Chu
Date: Wed May 13 2020 - 21:37:34 EST
Hi Tao,
On Thu, 2020-05-14 at 09:26 +0800, ChenTao wrote:
> Fix the following warning:
>
> drivers/scsi/ufs/ufs-mediatek.c:585:6: warning:
> symbol 'ufs_mtk_fixup_dev_quirks' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: ChenTao <chentao107@xxxxxxxxxx>
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index c543142554d3..73e4a4f9a3a2 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -582,7 +582,7 @@ static int ufs_mtk_apply_dev_quirks(struct ufs_hba *hba)
> return 0;
> }
>
> -void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba)
> +static void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba)
> {
> struct ufs_dev_info *dev_info = &hba->dev_info;
> u16 mid = dev_info->wmanufacturerid;
Thanks for fixing this.
Reviewed-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx>