Re: [PATCH 1/6] dt-bindings: omap: Update PRM binding for genpd

[Tero Kristo]

On 12/05/2020 23:38, Tony Lindgren wrote:
> The PRM (Power and Reset Module) has registers to enable and disable
> power domains, so let's update the binding for that.
>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
>   Documentation/devicetree/bindings/arm/omap/prm-inst.txt | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
> --- a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
> +++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
> @@ -18,12 +18,16 @@ Required properties:
>   		(base address and length)
>   
>   Optional properties:
> +- #power-domain-cells:	Should be 0 if the PRM instance is a power domain.
>   - #reset-cells:	Should be 1 if the PRM instance in question supports resets.
> +- clocks: Functional and interface clocks managed by the power domain
> +- clock-names: Names for the clocks using "fck" and "ick" naming

Whats the purpose of the clocks for PRM? It looks like you are using 
this with ABE domain on omap4/omap5, but why is this needed?

-Tero

>   
>   Example:
>   
>   prm_dsp2: prm@1b00 {
>   	compatible = "ti,dra7-prm-inst", "ti,omap-prm-inst";
>   	reg = <0x1b00 0x40>;
> +	#power-domain-cells = <0>;
>   	#reset-cells = <1>;
>   };

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki